Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanation mounting named volumes for podman run #3817

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Add explanation mounting named volumes for podman run #3817

merged 3 commits into from
Sep 10, 2019

Conversation

cognition9144
Copy link
Contributor

Fixes #3811

@openshift-ci-robot
Copy link
Collaborator

Hi @xcffl. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 15, 2019
@cognition9144
Copy link
Contributor Author

Also adds explanation about configuring fuse-overlayfs on rootless mode

@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@mheon
Copy link
Member

mheon commented Aug 15, 2019

/ok-to-test
/approve

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, xcffl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
mheon
mheon reviewed Aug 15, 2019
View reviewed changes
docs/podman-run.1.md Outdated Show resolved Hide resolved
@mheon
Copy link
Member

mheon commented Aug 15, 2019

Both commits need signoffs (can add via git commit --amend -s, but you'll have to do a rebase -i to hit both)

@rhatdan
Copy link
Member

rhatdan commented Aug 15, 2019

LGTM
Thanks @xcffl

@rhatdan
Copy link
Member

rhatdan commented Aug 15, 2019

Looks like the tests are complaining about some additional whitespace?

@TomSweeneyRedHat
Copy link
Member

Few comments, thanks for the PR @xcffl !

@baude
Copy link
Member

baude commented Aug 15, 2019

please add an appropriate commit message

@baude
Copy link
Member

baude commented Aug 15, 2019

you need to run make validate on your commits and repush

@cognition9144
Add instructions for mounting named volumes
cd7a1ac 
from the host for `podman run`

Signed-off-by: xcffl <xcffl@outlook.com>
@cognition9144
Replace "podman" with "Podman"
3d240bd 
Signed-off-by: xcffl <xcffl@outlook.com>
@cognition9144
Copy link
Contributor Author

cognition9144 commented Sep 10, 2019 •
edited
Loading

I think everything is fixed now @baude

TomSweeneyRedHat
TomSweeneyRedHat reviewed Sep 10, 2019
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and happy green test buttons.

@mheon
Copy link
Member

mheon commented Sep 10, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2019
@mheon
Copy link
Member

mheon commented Sep 10, 2019

We're having some CI trouble so the Prow tests may fail to re-run for the merge. We'll see.

@openshift-merge-robot openshift-merge-robot merged commit c1761ba into containers:master Sep 10, 2019
This was referenced Sep 10, 2019
Merged
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@mheon mheon mheon left review comments

@baude baude Awaiting requested review from baude

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc] podman run doesn't elaborate about named volumes
8 participants
@cognition9144 @openshift-ci-robot @rh-atomic-bot @mheon @rhatdan @TomSweeneyRedHat @baude @openshift-merge-robot